CB-5738 api for tokens #3023
Merged
CB-5738 api for tokens #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/bundles/io.cloudbeaver.service.security/db/cb_schema_update_22.sql
Outdated
Show resolved
Hide resolved
…oken' into CB-5738-te-support-user-access-token
| @@ -148,6 +148,13 @@ type UserTeamInfo { | |||
| teamRole: String | |||
| } | |||
|
|
|||
| type APITokenInfo @since(version: "24.2.4") { | |||
There was a problem hiding this comment.
move to a separate plugin
There was a problem hiding this comment.
and create separate model for create/list requests
| type APITokenInfo @since(version: "24.2.4") { | ||
| tokenName: String! | ||
| token: String | ||
| periodDays: Int! |
There was a problem hiding this comment.
expiredAt/expirationTime/etc instead of period
server/bundles/io.cloudbeaver.service.security/db/cb_schema_update_22.sql
Show resolved
Hide resolved
Wroud
approved these changes
Oct 29, 2024
devnaumov
approved these changes
Oct 29, 2024
Wroud
reviewed
Oct 30, 2024
| @@ -67,7 +67,7 @@ export function useAuthDialogState(accessRequest: boolean, providerId: string | | |||
| const providers = authProvidersResource.data.filter(notEmptyProvider).sort(compareProviders); | |||
|
|
|||
| const activeProviders = providers.filter(provider => { | |||
| if (provider.federated || provider.trusted || provider.private) { | |||
| if (provider.federated || provider.trusted || provider.private || provider.authHidden) { | |||
There was a problem hiding this comment.
why we can't use private? or trusted
There was a problem hiding this comment.
private does not fit here due to the fact we won't see the setting in the server config
trusted does not fit also here, but not sure why - the backend said so
we had a call with all of the flags which can fit to our needs, so we decided to extend the scheme cause there was no best candidate to fit our needs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.